Configure log timestamp format #5050
Conversation
SVilgelm
force-pushed
the
log-timestamp-format
branch
from
a1539d4
to
8ca7a50
Compare
|
@SVilgelm thanks for the contribution. It would be great if you could add some unit tests. Thanks. |
I would be glad to do it, but need some hints. What do you think is the best place for testing new cli argument? I did not find any tests for the log-format or log-level args |
|
I would have imagined a simple test which collects the log output with the |
|
@SVilgelm You might be able to build off of the existing end-to-end logging tests. I think there's at least one test case there that checks to make sure the decision log JSON has the correct keys present-- that can almost certainly be upgraded into a check for the timestamp matching a regex for a custom format. |
|
@ashutosh-narkar @philipaconrad I added the additional unit test in |
SVilgelm
force-pushed
the
log-timestamp-format
branch
from
5369ba3
to
e73cd05
Compare
let user to configure the log's timestamp format by: * cli argument `log-timestamp-format` * environment variable `OPA_LOG_TIMESTAMP_FORMAT` Closes open-policy-agent#2413 Signed-off-by: Sergey Vilgelm <[email protected]>
Signed-off-by: Sergey Vilgelm <[email protected]>
SVilgelm
force-pushed
the
log-timestamp-format
branch
from
e73cd05
to
b5872f9
Compare
| checkLogTimeStampFormat(t, params, format) | ||
| }) | ||
| t.Run("environment variable", func(t *testing.T) { | ||
| t.Setenv("OPA_LOG_TIMESTAMP_FORMAT", format) |
There was a problem hiding this comment.
Neat. I didn't know that function. Pretty handy. https://pkg.go.dev/testing#T.Setenv
let user to configure the log's timestamp format by:
log-timestamp-formatOPA_LOG_TIMESTAMP_FORMATCloses #2413
Signed-off-by: Sergey Vilgelm [email protected]